[BUGFIX] gateway filter was not applied #289
Merged
+27
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application of the gateway filter did not know about the nodeData and could not add it when calling the filter. Instead, we now define the nodeData dependent filter for selectedGatewayIP at runtime.
maurerle
force-pushed
the
fix_gateway_filter_behavior
branch
from
49c4b78 to
8bfd496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The application of the gateway filter did not know about the nodeData and could not add it when calling the filter. Instead, we now define the nodeData dependent filter for selectedGatewayIP at runtime.
Motivation and Context
The selectedGatewayIP filter did not work.
Fixes #278
How Has This Been Tested?
Screenshots/links:
Checklist: